Exclude cherry-pick-stable script from crates.io package #4748
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
stable-nominated
|
JohnTitor
force-pushed
the
exlcude-cherry-pick-script
branch
from
f1e81fe to
e00110f
Compare
JohnTitor
removed
the
stable-nominated
The label is used when a PR should be backported to 0.2 from main, so it's unnecessary in this case. But anyway thanks for caring :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing dependencies at my company I noticed that with libc 0.2.177 the
cherry-pick-stable.shscript showed up in the package published to crates.io. I suspect that it is not required to be shipped and I open this PR to exclude it from the package. This makes code review for supply chain safety a bit easier because we don't have to review future changes to the script and not having a script in the published package is also a good thing. :)Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
Since this is targeting 0.2 I think the stable label is warrented? Sorry if I'm getting something wrong here. 😅
@rustbot label +stable-nominated